Fix migration namespace and callback #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Jun 4, 2019
| @@ -84,7 +84,7 @@ public function create_wordpress_connection( $app_token, $migration_enabled, $pa | |||
| 'bareConfiguration' => array( | |||
| 'endpointUrl' => site_url( 'index.php?a0_action=' ), | |||
| 'migrationToken' => $migration_token, | |||
| 'userNamespace' => get_auth0_curatedBlogName(), | |||
| 'userNamespace' => 'DB-' . get_auth0_curatedBlogName(), | |||
There was a problem hiding this comment.
This is for new installations and has not been released yet so OK to change.
joshcanhelp
commented
Jun 4, 2019
| @@ -217,9 +217,6 @@ protected function migration_ws_get_user() { | |||
| $username = $_POST['username']; | |||
|
|
|||
| $user = get_user_by( 'email', $username ); | |||
| if ( ! $user ) { | |||
There was a problem hiding this comment.
This endpoint should only used be used to check the email address.
joshcanhelp
commented
Jun 4, 2019
| @@ -66,6 +66,7 @@ public function call( $user_id = null, $email = null ) { | |||
| ->add_body( 'email', $email ) | |||
| // Email is either changed by an admin or verified by WP. | |||
| ->add_body( 'email_verified', true ) | |||
| ->add_body( 'client_id', $this->options->get( 'client_id' ) ) | |||
There was a problem hiding this comment.
Recommended by the API docs for this endpoint
damieng
approved these changes
Jun 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
client_idto the update user API callTesting
Checklist