Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post passwords getting redirected #698

Merged
merged 3 commits into from
Jul 29, 2019

Conversation

joshcanhelp
Copy link
Contributor

Changes

Content with a password is getting redirected to the ULP.

Testing

To manually test before the fix:

  1. Turn on Auth0 > Settings > Features > Universal Login Page
  2. Create a new post or page
  3. Set Visibility to Password Protected

Screenshot 2019-07-16 09 39 41

  1. View the post or page
  2. Enter the password and submit
  3. Redirected to the ULP (bad)
  4. Apply the fix
  5. Try steps 4 and 5 above
  6. See the password-protected content
  • I included manual testing steps above, if applicable
  • This change adds unit test coverage
  • This change has been tested in WP 5.2.2

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp added this to the 3.11.1 milestone Jul 16, 2019
@joshcanhelp joshcanhelp requested a review from a team July 16, 2019 16:42
@joshcanhelp joshcanhelp changed the base branch from master to wordpress-org-plugin July 16, 2019 17:52
@joshcanhelp joshcanhelp merged commit 12a28f0 into wordpress-org-plugin Jul 29, 2019
@joshcanhelp joshcanhelp deleted the fix-post-passwords branch July 29, 2019 21:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants