Fix embed widget documentation and validation #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Jul 29, 2019
| @@ -32,7 +32,7 @@ | |||
| "scripts": { | |||
| "compat": "\"vendor/bin/phpcs\" --standard=phpcs-compat-ruleset.xml .", | |||
| "phpcs": "\"vendor/bin/phpcs\"", | |||
| "phpcs-i18n": "\"vendor/bin/phpcs\" --sniffs=WordPress.WP.I18n ./lib/", | |||
| "phpcs-i18n": "\"vendor/bin/phpcs\" --sniffs=WordPress.WP.I18n", | |||
There was a problem hiding this comment.
Missing files from the translation check
joshcanhelp
commented
Jul 29, 2019
| } | ||
|
|
||
| if ( ! empty( $new_instance['redirect_to'] ) ) { |
There was a problem hiding this comment.
Redirect URL now uses the same validation as the settings page.
joshcanhelp
commented
Jul 29, 2019
| </p> | ||
|
|
||
| <?php if ( $custom_css ) : ?> |
There was a problem hiding this comment.
Do not show the field if empty to avoid new data to be saved (this option is deprecated).
joshcanhelp
force-pushed
the
add-logged-in-notice
branch
from
d3bdaf6 to
24a6138
Compare
joshcanhelp
commented
Jul 29, 2019
| </p> | ||
| <?php endif; ?> | ||
|
|
||
| <?php if ( $custom_js ) : ?> |
There was a problem hiding this comment.
Do not show the field if empty to avoid new data to be saved (this option is deprecated).
damieng
approved these changes
Jul 30, 2019
joshcanhelp
force-pushed
the
add-logged-in-notice
branch
2 times, most recently
from
f24c5b7 to
1316c23
Compare
joshcanhelp
force-pushed
the
add-logged-in-notice
branch
from
1316c23 to
4551644
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note to reviewers: changes to the PO, MO, and POT files are automated. If the text in the main template file being changed,
templates/a0-widget-setup-form.php, looks good, then these will be fine as well. Marking this as "small" as it's mostly verbiage changes.Testing
Checklist