Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove features including SSO on wp-login/php #723

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Sep 24, 2019

Changes

Removes deprecated settings, including SSO check on wp-login.php. If SSO is required, turn on Features > Universal Login Page on the Auth0 plugin settings page.

Specifics:

  • Remove deprecated WP_Auth0_Lock10_Options::get_sso() method
  • Remove unused WP_Auth0_Lock10_Options::get_sso_options() method
  • Remove deprecated WP_Auth0_LoginManager::auth0_sso_footer() method
  • Remove deprecated WP_Auth0_LoginManager::auth0_singlelogout_footer() method
  • Remove deprecated WP_Auth0_Admin_Features::render_password_policy() method
  • Remove deprecated WP_Auth0_Admin_Features::render_sso() method
  • Remove deprecated WP_Auth0_Admin_Features::render_passwordless_enabled() method
  • Remove deprecated WP_Auth0_Admin_Features::render_mfa() method
  • Remove deprecated WP_Auth0_Admin_Features::render_fullcontact() method
  • Remove deprecated WP_Auth0_Admin_Features::render_fullcontact_apikey() method
  • Remove deprecated WP_Auth0_Admin_Features::render_geo() method
  • Remove deprecated WP_Auth0_Admin_Features::render_income() method
  • Remove unused WP_Auth0_Admin_Features::sso_validation() method
  • Remove deprecated WP_Auth0_Admin_Features::security_validation() method
  • Remove deprecated WP_Auth0_Admin_Features::fullcontact_validation() method
  • Remove deprecated WP_Auth0_Admin_Features::mfa_validation() method
  • Remove deprecated WP_Auth0_Admin_Features::georule_validation() method
  • Remove deprecated WP_Auth0_Admin_Features::incomerule_validation() method
  • Remove deprecated WP_Auth0_Admin_Features::render_features_description() method

Note to reviewers: Changes to PO, MO, and POT files are just removing now-unused translations.

Testing

  • This change modifies unit test coverage
  • This change has been tested on WP 5.2.2

@joshcanhelp joshcanhelp requested a review from a team September 24, 2019 14:52
@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Sep 24, 2019
@joshcanhelp joshcanhelp merged commit 3f89d3b into master Sep 24, 2019
@joshcanhelp joshcanhelp deleted the remove-features-settings branch September 24, 2019 15:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants