Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated from admin #748

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Dec 10, 2019

Changes

Note to reviewers: Around 2/3s of the lines added are new tests. Most of the functionality "added" here existed in different methods.

  • Move WP_Auth0_Settings_Section::init_menu() method to new wp_auth0_init_admin_menu() function
  • Remove WP_Auth0_Settings_Section class
  • Rename wpa0_admin_initial_settup style to wpa0_admin_initial_setup
  • Move WP_Auth0_Admin::create_account_message() method to new wp_auth0_create_account_message() function
  • Remove WP_Auth0_Admin::init() method
  • Remove WP_Auth0_Admin::cant_connect_to_auth0() method
  • Remove WP_Auth0_Admin_Generic::rule_validation() method
  • Remove WP_Auth0_Admin_Generic::render_a0_switch() method
  • Only load core WP media styles and scripts on settings page.

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.3

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp force-pushed the remove-deprecated-from-admin branch 3 times, most recently from ce17a42 to 8a4ad60 Compare December 10, 2019 05:15
@joshcanhelp joshcanhelp force-pushed the remove-deprecated-from-admin branch from 8a4ad60 to a71f2ab Compare December 10, 2019 05:23
@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Dec 10, 2019
@joshcanhelp joshcanhelp marked this pull request as ready for review December 10, 2019 17:04
@joshcanhelp joshcanhelp requested a review from a team December 10, 2019 17:04
lib/admin/WP_Auth0_Admin.php Show resolved Hide resolved
composer.json Show resolved Hide resolved
tests/testWPAuth0DbMigrations.php Show resolved Hide resolved
@joshcanhelp joshcanhelp requested a review from damieng December 13, 2019 17:58
@joshcanhelp joshcanhelp merged commit 5923ed8 into master Dec 13, 2019
@joshcanhelp joshcanhelp deleted the remove-deprecated-from-admin branch December 13, 2019 20:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants