Move actions from methods to functions for profile delete and change email #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
changed the title
joshcanhelp
commented
Dec 16, 2019
| * | ||
| * @param int $user_id - WordPress user ID. | ||
| */ | ||
| public function delete_auth0_object( $user_id ) { |
There was a problem hiding this comment.
Moved this to wp_auth0_delete_auth0_object() to avoid an unnecessary dependency injection.
5 tasks
damieng
approved these changes
Dec 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
WP_Auth0_UsersRepo::delete_auth0_object()towp_auth0_delete_auth0_object()WP_Auth0_Profile_Change_Email::init()WP_Auth0_UsersRepodependency fromWP_Auth0_Profile_Delete_DataconstructorWP_Auth0_Profile_Delete_Data::init()Testing
Checklist