Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bootstrap, fonts, and descriptions from admin pages #764

Merged
merged 5 commits into from
Jan 27, 2020

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Jan 25, 2020

Changes

  • Remove outdated Bootstrap JS and CSS from admin screens (corrects a number of display issues that appear in v3)
  • Use default WordPress admin font
  • Removed Enterprise setup option (was showing an outdated list of enterprise connections, did not provide any additional functionality in the plugin)
  • Adjusted the setup wizard steps for simplicity
  • Removed class WP_Auth0_InitialSetup_EnterpriseConnection
  • Removed protected property WP_Auth0_InitialSetup->enterprise_connection_step
  • Removed public method WP_Auth0_Admin_Generic->render_description() and protected property WP_Auth0_Admin_Generic->_description

Note for reviewers: Turning off whitespace changes will help. Please note that the admin documentation did not change much from what it was originally.

Settings screen

Screenshot 2020-01-25 13 51 31

Setup Wizard step 1 screen

Screenshot 2020-01-25 13 51 53

Import/Export Settings screen

Screenshot 2020-01-25 13 52 04

Testing

  • This change adds unit test coverage
  • This change has been tested on PHP 7.1 and WP 5.3.2

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All relevant assets have been compiled as directed in the Contribution guide, if applicable
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Jan 25, 2020
<input type="text" name="apitoken" class="js-a0-setup-input" autocomplete="off" required>
<p>
<small>
<form action="options.php" method="POST">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of whitespace and HTML adjustment. Documentation wording only saw minor changes.

@joshcanhelp joshcanhelp marked this pull request as ready for review January 25, 2020 21:58
@joshcanhelp joshcanhelp requested a review from a team January 25, 2020 21:58
@joshcanhelp joshcanhelp merged commit 8efa6b1 into master Jan 27, 2020
@joshcanhelp joshcanhelp deleted the remove-admin-styles branch January 27, 2020 15:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants