Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all redirects to wp_safe_redirect #771

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Change all redirects to wp_safe_redirect #771

merged 1 commit into from
Jan 31, 2020

Conversation

joshcanhelp
Copy link
Contributor

Changes

Change all instances of wp_redirect to wp_safe_redirect and filter necessary hosts.

References

https://developer.wordpress.org/reference/functions/wp_safe_redirect/

https://developer.wordpress.org/reference/hooks/allowed_redirect_hosts/

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.3 and PHP 7.1

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp requested a review from a team January 30, 2020 22:44
@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Jan 30, 2020
@joshcanhelp joshcanhelp merged commit 0e9c06d into master Jan 31, 2020
@joshcanhelp joshcanhelp deleted the change-all-redirects-to-safe branch January 31, 2020 18:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @lbalmaceda