Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect function in uninstall hook #795

Merged
merged 1 commit into from
May 20, 2020
Merged

Fix incorrect function in uninstall hook #795

merged 1 commit into from
May 20, 2020

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented May 20, 2020 •
edited
Loading

Description

Fix an incorrect function loaded in the uninstall hook

@joshcanhelp joshcanhelp requested a review from a team May 20, 2020 03:58
@joshcanhelp joshcanhelp added this to the 4.1.0 milestone May 20, 2020
@joshcanhelp joshcanhelp mentioned this pull request May 20, 2020
Merged
lbalmaceda
lbalmaceda approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there a way to tests the hooks are "registered" as expected?

@joshcanhelp
Copy link
Contributor Author

@lbalmaceda - There is but this one hook is odd in that it only works when the plugin is removed from the site, not like other hooks.

@joshcanhelp joshcanhelp merged commit b662dcf into master May 20, 2020
@joshcanhelp joshcanhelp deleted the fix-uninstall-hook branch May 20, 2020 22:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @lbalmaceda