Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filters on user queries #812

Merged
merged 5 commits into from
Feb 2, 2021

Conversation

tharsheblows
Copy link
Contributor

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

This adds the filters described in #811 which allow developers to use custom tables to store, retrieve and manipulate the returned Auth0 data for a user. They mimic, as closely as possible, the filters on the WordPress core filters for getting, updating and deleting metadata.

References

Discussion in #811.

Testing

There are phpunit tests for each of the filters. (Currently you have to apply the patch that's in the WP core issue here).

  • [+] This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • [+] All active GitHub checks for tests, formatting, and security are passing
  • [+] The correct base branch is being used, if not master

@tharsheblows tharsheblows requested a review from a team as a code owner December 10, 2020 13:22
@evansims evansims closed this Feb 2, 2021
@evansims evansims reopened this Feb 2, 2021
@evansims evansims self-requested a review February 2, 2021 14:53
@evansims evansims added this to the 4.2.0 milestone Feb 2, 2021
Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 👍 Sorry for the delay in reviewing but had to fix our test suite up a bit before I could address this. Thanks for your contributions on this, @tharsheblows! Much appreciated!

@evansims evansims merged commit 84269af into auth0:master Feb 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants