Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biometric_storage does not build with Java 21 #117

Closed
connyduck opened this issue Jun 27, 2024 · 4 comments · Fixed by #118
Closed

biometric_storage does not build with Java 21 #117

connyduck opened this issue Jun 27, 2024 · 4 comments · Fixed by #118

Comments

@connyduck
Copy link
Contributor

We are upgrading our project to Java 21 and the only package that is causing issues is biometric_storage.
Yes, a possible workaround is to have both JDK 17 and 21 installed via gradle toolchains, but it would be very nice to need only one, e.g. for CI/CD.
Please check if you can make biometric_storage work with Java 17 and up instead of explicitly requiring 17.

@hpoul
Copy link
Collaborator

hpoul commented Jun 27, 2024

since the code is all kotlin, this should be a pretty minor change.. feel free to provide a PR, I should be able to review it pretty quickly..

@hpoul
Copy link
Collaborator

hpoul commented Jun 28, 2024

thanks, i actually haven't tested it (yet), maybe you could give 5.1.0-rc.4 a try. 😅

@connyduck
Copy link
Contributor Author

connyduck commented Jul 11, 2024

@hpoul 5.1.0-rc.4 works fine in a Java 21 only and a 17 only project now! When will 5.1.0 be released?

@GuvanchBayryyyev
Copy link

it still gives me an error
Execution failed for task ':biometric_storage:compileReleaseJavaWithJavac'.
> error: invalid source release: 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants