Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importBulkRelationships or bulkImportRelationships? #170

Closed
branks opened this issue Oct 24, 2024 · 3 comments · Fixed by #181
Closed

importBulkRelationships or bulkImportRelationships? #170

branks opened this issue Oct 24, 2024 · 3 comments · Fixed by #181

Comments

@branks
Copy link

branks commented Oct 24, 2024

It seems bulkImportRelationships is inside of an "experiements" folder whereas importBulkRelationships is not which leads me to use importBulkRelationships

But, it seems the types are wrong for importBulkRelationships as the below code is valid typescript but if I debug it at runtime, it seems writeStream is a pending promise

const writeStream = this.client.importBulkRelationships((err, value) => {
writeStream.write(...)

image

@tstirrat15
Copy link
Contributor

Hey, apologies for being late to this one. bulkImport and importBulk are theoretically equivalent implementations with identical behavior. I'm not sure why typescript is misreporting the type here. I'll have a look at it.

@tstirrat15
Copy link
Contributor

I see the problem. Let me see about getting a fix.

@tstirrat15
Copy link
Contributor

I just released what should be a fix in v1.1.1. Can you give it a try and let me know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants