Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutomergeText and Counter reflect any change to a doc #150

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

heckj
Copy link
Collaborator

@heckj heckj commented Apr 29, 2024

fixes #149 in the quickest, dirtiest way possible

  • in the process of this, I expanded the scope (possibly stupidly) and updated the AutomergeText() initializers to establish schema if possible (no conflict allowed - won't change existing schema) when initializing with a path.
  • updated the tests to show that a change happens, but it's basic and doesn't show that changes signals occur no matter WHAT change happened to a doc
  • updated Tests to remove trackForLeak on AutomergeText and Counter usage since those now maintain a reference to the Document instance in order to watch for changes.

@heckj heckj self-assigned this Apr 29, 2024
@heckj heckj merged commit c148eb5 into main Apr 29, 2024
4 checks passed
@heckj heckj deleted the doc-change-signal branch April 29, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutomergeText doesn't have any change notification triggered on doc updates
1 participant