From be9ca70585a845298261af7aca236112eef892a3 Mon Sep 17 00:00:00 2001 From: Carolin Benjamins Date: Thu, 9 Sep 2021 11:40:29 +0200 Subject: [PATCH 1/4] fix docstring --- smac/runhistory/runhistory2epm.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/smac/runhistory/runhistory2epm.py b/smac/runhistory/runhistory2epm.py index 9c1ef624f..95a91d215 100644 --- a/smac/runhistory/runhistory2epm.py +++ b/smac/runhistory/runhistory2epm.py @@ -62,8 +62,8 @@ def __init__( num_params : int number of parameters in config space success_states: list, optional - List of states considered as successful (such as StatusType.SUCCESS) - If None, set to [StatusType.SUCCESS, ] + List of states considered as successful (such as StatusType.SUCCESS). + If None, raises TypeError. impute_censored_data: bool, optional Should we impute data? consider_for_higher_budgets_state: list, optional From 95609410eeace8acd2528818241c28ae48629112 Mon Sep 17 00:00:00 2001 From: Carolin Benjamins Date: Thu, 9 Sep 2021 11:45:46 +0200 Subject: [PATCH 2/4] fix docstring for impute_state --- smac/runhistory/runhistory2epm.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/smac/runhistory/runhistory2epm.py b/smac/runhistory/runhistory2epm.py index 95a91d215..3fd2902ea 100644 --- a/smac/runhistory/runhistory2epm.py +++ b/smac/runhistory/runhistory2epm.py @@ -73,7 +73,8 @@ def __init__( impute_state: list, optional List of states that mark censored data (such as StatusType.TIMEOUT) in combination with runtime < cutoff_time - If None, set to [StatusType.CAPPED, ] + If None, set to empty list []. + If None and impute_censored_data is True, raise TypeError. scale_perc: int scaled y-transformation use a percentile to estimate distance to optimum; only used by some subclasses of AbstractRunHistory2EPM From 769e0b80ac9fb05e4d36774b3222215262c7c667 Mon Sep 17 00:00:00 2001 From: Carolin Benjamins Date: Thu, 9 Sep 2021 11:46:27 +0200 Subject: [PATCH 3/4] added more info for rng --- smac/runhistory/runhistory2epm.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/smac/runhistory/runhistory2epm.py b/smac/runhistory/runhistory2epm.py index 3fd2902ea..2af86967a 100644 --- a/smac/runhistory/runhistory2epm.py +++ b/smac/runhistory/runhistory2epm.py @@ -79,7 +79,8 @@ def __init__( scaled y-transformation use a percentile to estimate distance to optimum; only used by some subclasses of AbstractRunHistory2EPM rng : numpy.random.RandomState - only used for reshuffling data after imputation + Only used for reshuffling data after imputation. + If None, use np.random.RandomState(seed=1). """ self.logger = logging.getLogger( From fd3d97a8c03d0b37748c24804a03c35e001661db Mon Sep 17 00:00:00 2001 From: Carolin Benjamins Date: Thu, 9 Sep 2021 11:46:54 +0200 Subject: [PATCH 4/4] remove 's' --- smac/runhistory/runhistory2epm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/smac/runhistory/runhistory2epm.py b/smac/runhistory/runhistory2epm.py index 2af86967a..3fc829b6e 100644 --- a/smac/runhistory/runhistory2epm.py +++ b/smac/runhistory/runhistory2epm.py @@ -63,7 +63,7 @@ def __init__( number of parameters in config space success_states: list, optional List of states considered as successful (such as StatusType.SUCCESS). - If None, raises TypeError. + If None, raise TypeError. impute_censored_data: bool, optional Should we impute data? consider_for_higher_budgets_state: list, optional