Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeSignatureVerification for signed apps #48

Open
homebysix opened this issue Oct 1, 2015 · 4 comments
Open

Add CodeSignatureVerification for signed apps #48

homebysix opened this issue Oct 1, 2015 · 4 comments

Comments

@homebysix
Copy link
Member

Would be great for those of us who are writing recipes that use yours as a ParentRecipe if you were to add CodeSignatureVerification to your .download recipes, where applicable. I'd be happy to help, if you're open to it.

@aysiu
Copy link
Contributor

aysiu commented Jul 8, 2016

Not really sure how to add this download recipe for FileZilla and test it, but the code signature verification should be:
identifier "de.filezilla" and anchor apple generic and certificate 1[field.1.2.840.113635.100.6.2.6] /* exists */ and certificate leaf[field.1.2.840.113635.100.6.1.13] /* exists */ and certificate leaf[subject.OU] = "5VPGKXL75N"

@grahampugh
Copy link

Adding CodeSignatureVerifier to FileZilla seems to have broken the recipe.

Processing FileZilla.jss...
FileZillaURLProvider
FileZillaURLProvider: Found URL https://dl1.cdn.filezilla-project.org/FileZilla_3.34.0_macosx-x86.app.tar.bz2
URLDownloader
URLDownloader: Storing new Last-Modified header: Fri, 15 Jun 2018 14:57:20 GMT
URLDownloader: Storing new ETag header: "5b23d3d0-a457c2"
URLDownloader: Downloaded /Users/---/Library/AutoPkg/Cache/local.jss.FileZilla/downloads/FileZilla.tar.bz2
EndOfCheckPhase
CodeSignatureVerifier
Error processing path '/Users/--/Library/AutoPkg/Cache/local.jss.FileZilla/downloads/FileZilla.app' with glob. 
Failed.

@aysiu
Copy link
Contributor

aysiu commented Jul 24, 2018

Tried to address it with this PR:
#92

@aysiu
Copy link
Contributor

aysiu commented Jul 24, 2018

Of course, that might mean the .munki recipe's unarchiver processor may be redundant:
https://github.com/autopkg/keeleysam-recipes/blob/master/FileZilla/FileZilla.munki.recipe#L37-L49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants