Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect argument parsing without options #185

Closed
Gerhut opened this issue Feb 24, 2020 · 9 comments · Fixed by #215
Closed

Incorrect argument parsing without options #185

Gerhut opened this issue Feb 24, 2020 · 9 comments · Fixed by #215

Comments

@Gerhut
Copy link
Contributor

Gerhut commented Feb 24, 2020

Describe the bug
get function changes every time when calling in useFetch(url, deps) format.

⚠️ Make a Codesandbox ⚠️
https://codesandbox.io/s/compassionate-carson-66sbu

Expected behavior
Keep optionsNoURLs undefined if second parameter is array in https://github.com/alex-cory/use-http/blob/master/src/useFetchArgs.ts#L72

@alex-cory
Copy link
Collaborator

On vacation until March 3, but will take a look asap.

@alex-cory
Copy link
Collaborator

Feel free to submit a PR! ❤️

@alex-cory
Copy link
Collaborator

This is my next thing I'm gonna work on. @maxquinn You interested in taking a look at this one? I'm either going to work on this or Suspense support tomorrow.

@maxquinn
Copy link
Contributor

maxquinn commented Mar 5, 2020

Yeah sure. I'll take a look in the morning

@alex-cory
Copy link
Collaborator

@maxquinn if this starts getting too far down a rabbit hole, let me know. Happy to help. We potentially might need to split loading state out of request object.

@alex-cory
Copy link
Collaborator

This is implemented in v0.4.1. Closing this issue. Let me know if the issue persists, and I'll re-open the issue.

@Gerhut
Copy link
Contributor Author

Gerhut commented Mar 29, 2020

Hi, it seems this is fixed after 2 major versions (I am reported in 0.2.9). Do we have some change logs or migration guides about these major version updates?

@alex-cory
Copy link
Collaborator

I am about to post a major release very soon. In that I will post all the updates, new features, etc! Bare with me.

@alex-cory
Copy link
Collaborator

@Gerhut Here's the new release! If you are having issues migrating to the new version, let me know your troubles and I will help as much as possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants