Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node.js --debug-port / --inspect workaround #997

Closed
sindresorhus opened this issue Aug 12, 2016 · 4 comments
Closed

Remove Node.js --debug-port / --inspect workaround #997

sindresorhus opened this issue Aug 12, 2016 · 4 comments
Labels
future we'll get back to this eventually help wanted scope:internals

Comments

@sindresorhus
Copy link
Member

When it's fixed in Node.js (nodejs/node#5025) itself and we target that version. So it's going to be a long while until we can. I'm just opening this so we don't forget.

The workaround was introduced in #874.

@sindresorhus sindresorhus added blocked waiting on something else to be resolved first future we'll get back to this eventually labels Aug 12, 2016
@sindresorhus
Copy link
Member Author

Sorry, forget to mention — nodejs/node#5025 only about --debug-port=0, but currently no issue about --inspect — please see nodejs/node#5025 (comment) "it should be possible to extend this to --inspect after this PR lands." Currently, --inspect should be used to achieve the best user debug experience (yeah, nodejs 7 is required). - @develar

@develar Could you open an issue on Node.js about the --inspect flag?

@develar
Copy link
Contributor

develar commented Aug 12, 2016

Blocked on nodejs/node#8080 (--inspect).

@sindresorhus
Copy link
Member Author

The fix landed in Node.js 8.1.0, so we can do this now.

@sindresorhus sindresorhus added help wanted and removed blocked waiting on something else to be resolved first labels May 2, 2019
@novemberborn
Copy link
Member

I did, in #2096.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future we'll get back to this eventually help wanted scope:internals
Projects
None yet
Development

No branches or pull requests

3 participants