-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maybe stop relying on "golint" #1705
Comments
it has nothing to do with golint. it's the go tool vet output. if you don't get it via golint edge cases can be fixed, but I even didn't seen before real-life use of that like piece of thanks for feedback, we appreciate it, but this time it's not relevant. |
Apologies, but there’s a zero percent chance it’s my error. If it was, my test suite would fail and go doc would fail to render the example. Neither of those things happen. I’ll find the root cause and submit a patch today to make that clear. |
basically, no, in your case it will work with tests and go doc, but go vet will indicate it as an error and will be right |
It's this issue: gojp/goreportcard#187 Also reported here: gojp/goreportcard#113 and here: https://goreportcard.com/report/github.com/arsham/expvastic also here: gojp/goreportcard#113 (comment) here's a discussion of an error in the handling of this situation inside "go vet": golang/go#22530. The result of the discussion is you should be using "go vet" directly, not "go tool vet". Which is another error, since goreportcard indicates it's using "go vet". Furthermore, I can't reproduce the error locally using "go tool vet" either, though this may be because I'm running tip. So, again, it's a problem with the tool, not a problem in my code. I only wish I'd bet you money on that outcome first. |
I'm not 100% sure what this is referring to:
I ran into one of the "piece of shit" edge cases while trying to update the x/crypto/ssh package: https://go-review.googlesource.com/c/crypto/+/80145#message-1d05ae3ca1b90b6041ab9d5e6edfc88e6e89f38c Others have as well, multiple times:
I'd also note the Code of Conduct expects you to exercise collaboration and respect in your speech, and marks 'demeaning' speech, such as (incorrectly) labeling code a "piece of shit", as unacceptable. https://github.com/avelino/awesome-go/blob/master/CODE_OF_CONDUCT.md |
note, that you just guessed the continuation of word from a list of options. also, this part of message was a joke and was not meant to be insulting to any Gopher at all. anyway, it's not changing the subject of this issue |
Oh, for sure man. There's exactly one word that typically follows "piece of sh", and *especially* only one word you'd feel the need to cross out and we both know what it is.
Your behavior in this entire thread is embarrassing.
|
Would also love to point you at the "Purpose" disclaimer for golint:
Which doesn't seem to match up with my interactions with contributors to this repository. |
@kevinburke I need to also point out that when I use golint/govet output to analyze repository, I assume that they can determine only most generic errors and I checking out every error if I can. |
There are a lot of problems with it and situations where it flags things that are not actually problems. This is confusing and discouraging. It also doesn't have a maintainer.
Just to name a few from the issues list.
golang/lint#354
golang/lint#350
golang/lint#286
Along with others I've run into, for example on #1698:
This is confusing, because there is an identifier named Load in that package, and godoc handles it with no problems; it looks like there's an error in the script generating the report card recommendation.
The text was updated successfully, but these errors were encountered: