-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to LoweredCodeUtils 2.4 #591
Conversation
Control-flow analysis changed considerably in LoweredCodeUtils 2.4 (xref JuliaDebug/LoweredCodeUtils.jl#87). This updates to the new version. The overall trend is less reliance on `norequire` as a way of blocking certain "bad" statements, instead attempting to discover minimal statements purely by their dependencies.
Any thoughts on moving |
Hmm, those |
JET Benchmark ResultJudge resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
JET Benchmark ResultJudge resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
|
Thanks for the update! I had been delaying the LCT update, so this is very helpful.
I believe this is a positive trend.
Absolutely! This is code I originally adapted from LightGraphs.jl a while back. While it doesn't have its own unit tests, it has been bug-free in JET's functionality so far. I'll review the most recent code from Graphs.jl and then attempt to create a PR to LCU. |
Control-flow analysis changed considerably in LoweredCodeUtils 2.4 (xref JuliaDebug/LoweredCodeUtils.jl#87). This updates to the new version. The overall trend is less reliance on `norequire` as a way of blocking certain "bad" statements, instead attempting to discover minimal statements purely by their dependencies.
Well, at least we don't get out of memory errors. I don't have time to dig into the failures any more today but I am interested in figuring out why things are failing, it could reveal further issues with LCU's current strategy. |
Thanks! I can look into these sometime this week. I am also planning to take a look on your PRs on LCU side again too. |
Would be nice to get this to hopefully unbreak JET on Julia master (at least it needs a newer LCU for master, not sure if that's already sufficient) |
Control-flow analysis changed considerably in LoweredCodeUtils 2.4
(xref JuliaDebug/LoweredCodeUtils.jl#87).
This updates to the new version. The overall trend is less
reliance on
norequire
as a way of blocking certain "bad"statements, instead attempting to discover minimal statements
purely by their dependencies.
Fixes #587