Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle accurate implementation #23

Closed
bombela opened this issue Jun 10, 2022 · 2 comments
Closed

Cycle accurate implementation #23

bombela opened this issue Jun 10, 2022 · 2 comments

Comments

@bombela
Copy link

bombela commented Jun 10, 2022

I am looking at implementing a cycle accurate solution. Pretty much identical to what the gcc-avr intrinsic does.
This was discussed in #17. Here is the code for reference: https://gist.github.com/bombela/cc90e5c29f3e7667326de4c087c1e148.

At the time of writing this, the implementation on master and rewrite are both not guaranteed to be expanded at compile time, and they are also not accurate.

Before I spend anytime working in this PR, I would like to know if you are interested in it. And if I should raise it against the rewrite branch.

@stappersg
Copy link
Member

Against branch cycacc, that is currently equal to master branch.

Yes, do read that as there is interest in a cycle accurate solution. It is the pretty much identical to what the GCC-AVR intrinsic does what makes it appealling.

Branch rewrite was created for finding out "what is the actual change?", name is based on title "Rewrote library to fix several issues" of #17. Some how it does feel like "rewrite just because we can", I prefer "change for a reason".

@bombela
Copy link
Author

bombela commented Jun 10, 2022

Ok!

@bombela bombela closed this as completed Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants