Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort bigendian builds #1921

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

ndim
Copy link
Contributor

@ndim ndim commented Sep 5, 2024

This tries to kind of fix #1917 by aborting builds for non-littleendian targets.

@mcuee mcuee added the enhancement New feature or request label Sep 5, 2024
@ndim
Copy link
Contributor Author

ndim commented Sep 5, 2024

Test build on and for s390x:

[...]
+ /usr/bin/cmake -S . -B redhat-linux-build -DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_INSTALL_DO_STRIP:BOOL=OFF -DCMAKE_INSTALL_PREFIX:PATH=/usr -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DLIB_SUFFIX=64 -DBUILD_SHARED_LIBS:BOOL=ON -D CMAKE_INSTALL_SYSCONFDIR:PATH=/etc -D CMAKE_BUILD_TYPE=build_type=RelWithDebInfo -D BUILD_DOC:BOOL=ON -D HAVE_LINUXSPI:BOOL=ON -D HAVE_LINUXGPIO:BOOL=ON -D HAVE_PARPORT:BOOL=ON -D FETCHCONTENT_FULLY_DISCONNECTED:BOOL=ON -D FETCHCONTENT_QUIET:BOOL=OFF -D BUILD_SHARED_LIBS:BOOL=NO -D USE_STATIC_LIBS:BOOL=YES
-- The C compiler identification is GNU 14.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
CMake Error at CMakeLists.txt:69 (message):
  avrdude cannot be built for a Big Endian target at this time
-- Configuring incomplete, errors occurred!
[...]

All the little endian builds from the CI continue to work. So this appears to work, and the remaining thing is commit message, comments, and error messages. Any input on those?

@ndim ndim force-pushed the abort-bigendian-builds branch from 54d1530 to e73b71b Compare September 5, 2024 01:59
@ndim ndim marked this pull request as ready for review September 5, 2024 02:01
Aborting the build at cmake/configure time with an error
message mentioning endianness is more user friendly than
producing an avrdude executable which kind of runs but
never works due to endianness problems.
@ndim ndim force-pushed the abort-bigendian-builds branch from e73b71b to 43040c5 Compare September 5, 2024 02:06
@ndim ndim marked this pull request as draft September 6, 2024 00:36
@ndim
Copy link
Contributor Author

ndim commented Sep 6, 2024

Back to draft PR as long as @dl8dtl #1917 (comment) is looking into making/keeping avrdude bigendian compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endianness related errors and warnings while running avrdude -c '*/u' on s390x
2 participants