Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version suffix #3

Draft
wants to merge 70 commits into
base: master
Choose a base branch
from
Draft

Add version suffix #3

wants to merge 70 commits into from

Conversation

ndim
Copy link

@ndim ndim commented Feb 24, 2024

Draft PR to save the work, more description to follow.

@mcuee mcuee added the enhancement New feature or request label Feb 24, 2024
@ndim ndim force-pushed the add-version-suffix branch 2 times, most recently from 08cf693 to 6e8099e Compare February 26, 2024 02:45
@ndim ndim mentioned this pull request Feb 26, 2024
@ndim ndim force-pushed the add-version-suffix branch from 5704b2c to c631626 Compare February 26, 2024 05:58
@mcuee mcuee mentioned this pull request Feb 26, 2024
@ndim ndim force-pushed the add-version-suffix branch 11 times, most recently from 0574156 to afe2353 Compare February 27, 2024 18:42
@mcuee mcuee mentioned this pull request Mar 24, 2024
3 tasks
ndim added 29 commits September 5, 2024 04:12
My VM with FreeBSD takes a bit more than 1050ms for the 1s
sleep, namely about 1072ms.

No idea what kind of problem this indicates.
This might address the following build warning/error:

```
D:/a/libserialport/libserialport/windows.c: In function 'get_port_details':
D:/a/libserialport/libserialport/windows.c:457:83: error: '%s' directive output may be truncated writing up to 31 bytes into a region of size between 20 and 31 [-Werror=format-truncation=]
  457 |                                         snprintf(usb_path, sizeof(usb_path), "%d%s%s",
      |                                                                                   ^~
  458 |                                                  (int)address, *tmp ? "." : "", tmp);
      |                                                                                 ~~~
D:/a/libserialport/libserialport/windows.c:457:41: note: 'snprintf' output between 2 and 44 bytes into a destination of size 32
  457 |                                         snprintf(usb_path, sizeof(usb_path), "%d%s%s",
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  458 |                                                  (int)address, *tmp ? "." : "", tmp);
      |                                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1.exe: all warnings being treated as errors
make[2]: *** [CMakeFiles/libserialport.dir/build.make:76: CMakeFiles/libserialport.dir/windows.c.obj] Error 1
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/libserialport.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
```
.gitattributes file might already work
@ndim ndim force-pushed the add-version-suffix branch from 6b4f513 to 34a8286 Compare September 5, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants