Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjParser multiple groups with 1 material #70

Closed
profelis opened this issue Aug 29, 2011 · 4 comments
Closed

ObjParser multiple groups with 1 material #70

profelis opened this issue Aug 29, 2011 · 4 comments
Assignees
Labels

Comments

@profelis
Copy link

Parser remove once used specular data

_materialSpecularData.splice(j, 1);

and others meshes dosnt find removed specular data

@ghost ghost assigned Fabrice3D Oct 8, 2011
@profelis
Copy link
Author

Still bug

@ghost ghost assigned richardolsson Jun 14, 2012
@richardolsson
Copy link
Member

This issue should be easily fixed by removing the splice. However, that has to wait until after a recently discussed modification to the shading method system internals which will allow shading method instances to be shared across several material instances.

@Fabrice3D In the meantime, do you have any objections to me simply removing this splice? I'm not sure why it's there in the first place and was hoping you might know.

@Fabrice3D
Copy link
Member

No not at all. Just looked at it, it's a mistake, should indeed be removed.

@richardolsson
Copy link
Member

Ok! I'll fix it Monday then, once the shading method refactor is in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants