Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add override and variant exports from ui-react to utils #1104

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Oct 6, 2023

Problem

ui-react is removing hooks and helpers from next major release

Solution

part1: add override and variant exports

Manual tests

imported utils file into local app

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jshhhh Jshhhh requested a review from a team as a code owner October 6, 2023 17:32
@codecov-commenter
Copy link

Codecov Report

Merging #1104 (a9a18e4) into main (7c00e4c) will decrease coverage by 0.58%.
The diff coverage is 39.68%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
- Coverage   94.00%   93.43%   -0.58%     
==========================================
  Files         125      131       +6     
  Lines        5957     6016      +59     
  Branches     1822     1831       +9     
==========================================
+ Hits         5600     5621      +21     
- Misses        339      373      +34     
- Partials       18       22       +4     
Files Coverage Δ
...ges/codegen-ui-react/lib/imports/import-mapping.ts 100.00% <ø> (ø)
packages/codegen-ui-react/lib/index.ts 100.00% <100.00%> (ø)
packages/codegen-ui-react/lib/overrides/index.ts 100.00% <100.00%> (ø)
packages/codegen-ui-react/lib/overrides/types.ts 100.00% <100.00%> (ø)
...s/codegen-ui-react/lib/react-component-renderer.ts 100.00% <100.00%> (ø)
...-react/lib/react-utils-studio-template-renderer.ts 91.48% <100.00%> (+0.18%) ⬆️
...degen-ui-react/lib/overrides/findChildOverrides.ts 33.33% <33.33%> (ø)
...codegen-ui-react/lib/overrides/getOverrideProps.ts 27.27% <27.27%> (ø)
...ui-react/lib/overrides/getOverridesFromVariants.ts 20.00% <20.00%> (ø)
...i-react/lib/overrides/mergeVariantsAndOverrides.ts 20.00% <20.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c00e4c...a9a18e4. Read the comment docs.

@Jshhhh Jshhhh merged commit 85ecd5e into main Oct 7, 2023
9 checks passed
@Jshhhh Jshhhh deleted the replace-react-hooks-1 branch October 7, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants