Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expander init #725

Merged
merged 1 commit into from
Oct 24, 2022
Merged

feat: expander init #725

merged 1 commit into from
Oct 24, 2022

Conversation

letsbelopez
Copy link
Contributor

Issue #, if available:

Description of changes:

Adds a new expander renderer under view renderer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@letsbelopez letsbelopez requested a review from a team as a code owner October 24, 2022 17:03
@codecov-commenter
Copy link

Codecov Report

Merging #725 (b4f77fa) into main (1c5cf33) will decrease coverage by 0.17%.
The diff coverage is 82.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
- Coverage   91.49%   91.31%   -0.18%     
==========================================
  Files         101      102       +1     
  Lines        3925     3996      +71     
  Branches     1092     1115      +23     
==========================================
+ Hits         3591     3649      +58     
- Misses        312      325      +13     
  Partials       22       22              
Impacted Files Coverage Δ
...erate-view-definition/generate-table-definition.ts 95.23% <50.00%> (-4.77%) ⬇️
.../lib/amplify-ui-renderers/amplify-view-renderer.ts 77.77% <71.42%> (-4.05%) ⬇️
...es/codegen-ui-react/lib/react-expander-renderer.ts 81.48% <81.48%> (ø)
.../codegen-ui-react/lib/views/react-view-renderer.ts 80.62% <92.30%> (+0.94%) ⬆️
packages/codegen-ui-react/lib/index.ts 100.00% <100.00%> (ø)
...odegen-ui-react/lib/react-table-renderer-helper.ts 82.50% <100.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5cf33...b4f77fa. Read the comment docs.

@letsbelopez letsbelopez merged commit bad7b04 into main Oct 24, 2022
@letsbelopez letsbelopez deleted the feat/expander branch October 24, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants