Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate Storagefield for form builder #976

Merged
merged 7 commits into from
Apr 5, 2023

Conversation

bombguy
Copy link
Contributor

@bombguy bombguy commented Apr 5, 2023

Problem

To support generate StorageField configured by form builder

Additional Notes

  • snapshot of the generate code
  • example data schema & form definition
  • workaround on the stringified array field

Verification

Manual tests

Manually tested the generated code by modifying the data schema & form definition.

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated - Deferred integ testing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Merging #976 (f97fa3d) into main (cfe9b60) will decrease coverage by 11.77%.
The diff coverage is 88.65%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #976       +/-   ##
===========================================
- Coverage   93.02%   81.26%   -11.77%     
===========================================
  Files         120      121        +1     
  Lines        5293     5370       +77     
  Branches     1578     1599       +21     
===========================================
- Hits         4924     4364      -560     
- Misses        348      935      +587     
- Partials       21       71       +50     
Impacted Files Coverage Δ
...s/codegen-ui-react/lib/react-component-renderer.ts 88.88% <61.11%> (-11.12%) ⬇️
...ct/lib/forms/form-renderer-helper/event-targets.ts 34.88% <83.33%> (-65.12%) ⬇️
...i-react/lib/utils/forms/storage-field-component.ts 93.87% <93.87%> (ø)
.../lib/amplify-ui-renderers/amplify-form-renderer.ts 18.80% <100.00%> (-22.07%) ⬇️
.../forms/form-renderer-helper/event-handler-props.ts 63.10% <100.00%> (-35.90%) ⬇️
...react/lib/forms/form-renderer-helper/form-state.ts 74.86% <100.00%> (-23.99%) ⬇️
.../lib/forms/form-renderer-helper/render-checkers.ts 100.00% <100.00%> (ø)
.../codegen-ui-react/lib/forms/react-form-renderer.ts 70.85% <100.00%> (-25.62%) ⬇️
packages/codegen-ui-react/lib/helpers/index.ts 96.29% <100.00%> (-3.71%) ⬇️
...ges/codegen-ui-react/lib/imports/import-mapping.ts 100.00% <100.00%> (ø)
... and 2 more

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfe9b60...f97fa3d. Read the comment docs.

@bombguy bombguy marked this pull request as ready for review April 5, 2023 02:37
@bombguy bombguy requested a review from a team as a code owner April 5, 2023 02:37
hein-j
hein-j previously approved these changes Apr 5, 2023
rtpascual
rtpascual previously approved these changes Apr 5, 2023
@bombguy bombguy dismissed stale reviews from rtpascual and hein-j via f97fa3d April 5, 2023 02:54
rtpascual
rtpascual previously approved these changes Apr 5, 2023
hein-j
hein-j previously approved these changes Apr 5, 2023
@hein-j hein-j dismissed stale reviews from rtpascual and themself via c2b8055 April 5, 2023 04:10
hein-j
hein-j previously approved these changes Apr 5, 2023
@hein-j hein-j merged commit b9f2bda into main Apr 5, 2023
@hein-j hein-j deleted the cshin/form-builder-storage-field branch April 5, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants