Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgot Password? text should be clickable #3046

Closed
hoang-innomize opened this issue Apr 9, 2019 · 6 comments
Closed

Forgot Password? text should be clickable #3046

hoang-innomize opened this issue Apr 9, 2019 · 6 comments
Assignees
Labels
Angular Related to Angular 2+ Auth Related to Auth components/category feature-request Request a new feature UI Related to UI Components

Comments

@hoang-innomize
Copy link

I have mentioned this issue on #2980. However, I think raising a separate issue will be easier for tracking

We should add a click event to the Forgot Password? text on the sign in form like Reset your password text. Per our user perspective, they have reported an issue, so I think we should make this change.

I tried to make this working by removing the forgot password text using i18n, however, I encounter another issue on the Reset password form (incorrect form title). We are using the same key for both text and form title. I would be better if we use separated keys

@alebiavati alebiavati added bug Something isn't working Angular Related to Angular 2+ needs-discussion Used for internal discussions enhancement and removed bug Something isn't working needs-discussion Used for internal discussions labels Apr 11, 2019
@jordanranz jordanranz added this to the UI Components Refactor milestone Apr 12, 2019
@jordanranz
Copy link
Contributor

@hoang-innomizetech, we are working on a UI refactor that will allow more granular customization for these UI components. I'll add this enhancement to our UI refactor milestone.

@hoang-innomize
Copy link
Author

@jordanranz I followed the milestone and I cannot see any update, do you have any ETA for UI Component Refactor milestone?

@jordanranz
Copy link
Contributor

Hey @hoang-innomizetech, I have referenced this issue in the RFC. Please feel free to add any additional comments to the following proposal:

#3279

@DeniseJames
Copy link

Any updates on this issue? When using the 'reset password' link the default username is displayed:

[object HTMLInputElement] instead a blank or username

@hoang-innomize
Copy link
Author

Anyone can help to fix this issue?

@sammartinez sammartinez added feature-request Request a new feature and removed enhancement labels Jun 17, 2019
@abdallahshaban557 abdallahshaban557 added Auth Related to Auth components/category UI Related to UI Components labels Jun 3, 2022
@tannerabread
Copy link
Contributor

This should be possible now as shown here. Closing this issue as resolved.

@tannerabread tannerabread self-assigned this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Angular Related to Angular 2+ Auth Related to Auth components/category feature-request Request a new feature UI Related to UI Components
Projects
None yet
Development

No branches or pull requests

7 participants