-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom-graph-signatures #743
Conversation
Codecov Report
@@ Coverage Diff @@
## master #743 +/- ##
========================================
- Coverage 86.6% 86.5% -0.1%
========================================
Files 74 74
Lines 3538 3542 +4
Branches 674 676 +2
========================================
Hits 3064 3064
- Misses 456 460 +4
Partials 18 18
Continue to review full report at Codecov.
|
I wasn't sure if I needed to worry about a test coverage drop this small. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I think we need to verify what is the expected behavior when is configured custom endpoints and appsync at the same time. Maybe a warning
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Fixes #696
Issue #, if available:
[(https://github.com//issues/696)]
Description of changes:
Adds the ability to sign custom graphql requests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.