Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add node auth tests to CircleCI #7915

Merged
merged 7 commits into from
Mar 12, 2021
Merged

chore: Add node auth tests to CircleCI #7915

merged 7 commits into from
Mar 12, 2021

Conversation

amhinson
Copy link
Contributor

@amhinson amhinson commented Mar 9, 2021

Description of changes:

  • Run Node.js integ tests for amazon-cognito-identity-js in CircleCI

Successful CircleCI run: https://app.circleci.com/pipelines/github/aws-amplify/amplify-js/7362/workflows/b6ca2c1d-742b-44c1-b691-e333c0fd34b4/jobs/34966

Integ sample & tests: https://github.com/aws-amplify/amplify-js-samples-staging/pull/206


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #7915 (96023fa) into main (5a6cecd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7915   +/-   ##
=======================================
  Coverage   74.26%   74.26%           
=======================================
  Files         215      215           
  Lines       13470    13470           
  Branches     2645     2645           
=======================================
  Hits        10004    10004           
  Misses       3268     3268           
  Partials      198      198           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cce7e6...96023fa. Read the comment docs.

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

Copy link
Member

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amhinson amhinson merged commit 7c8eb92 into main Mar 12, 2021
This was referenced Mar 13, 2021
This was referenced Mar 15, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
@jimblanc jimblanc deleted the add-node-auth-to-cci branch November 23, 2022 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants