From edf35be981bd74cff736b1590cc99b54041bfdfb Mon Sep 17 00:00:00 2001 From: Kevin DeJong Date: Mon, 8 Jul 2024 10:33:01 -0700 Subject: [PATCH] Fix testing as a result of schema changes --- test/fixtures/templates/good/resources_codepipeline.yaml | 2 +- test/unit/module/cfn_yaml/test_yaml.py | 2 +- test/unit/module/test_rules_collections.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/fixtures/templates/good/resources_codepipeline.yaml b/test/fixtures/templates/good/resources_codepipeline.yaml index 0e33cba476..b95fae277d 100644 --- a/test/fixtures/templates/good/resources_codepipeline.yaml +++ b/test/fixtures/templates/good/resources_codepipeline.yaml @@ -9,7 +9,7 @@ Resources: ArtifactStore: Location: 'pipeline-bucket' Type: S3 - RoleArn: arn:aws:iam:::role/AWSCodePipelineRole + RoleArn: !Sub "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/AWSCodePipelineRole" Stages: - Name: Source Actions: diff --git a/test/unit/module/cfn_yaml/test_yaml.py b/test/unit/module/cfn_yaml/test_yaml.py index 1b60db93ab..9a50893b15 100644 --- a/test/unit/module/cfn_yaml/test_yaml.py +++ b/test/unit/module/cfn_yaml/test_yaml.py @@ -27,7 +27,7 @@ def setUp(self): }, "generic_bad": { "filename": "test/fixtures/templates/bad/generic.yaml", - "failures": 28, + "failures": 27, }, } diff --git a/test/unit/module/test_rules_collections.py b/test/unit/module/test_rules_collections.py index 46e8aac53a..5282ec2437 100644 --- a/test/unit/module/test_rules_collections.py +++ b/test/unit/module/test_rules_collections.py @@ -69,7 +69,7 @@ def test_fail_run(self): filename = "test/fixtures/templates/bad/generic.yaml" template = cfnlint.decode.cfn_yaml.load(filename) cfn = Template(filename, template, ["us-east-1"]) - expected_err_count = 31 + expected_err_count = 30 matches = [] matches.extend(self.rules.run(filename, cfn)) assert (