Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When ref no value don't error for bad property #1038

Merged
merged 2 commits into from
Jul 22, 2019

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
Fix #1031

Description of changes:

  • Don't fail on rule E3002 when property has a value of !Ref: AWS::NoValue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c8cffeb). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1038   +/-   ##
=========================================
  Coverage          ?   86.83%           
=========================================
  Files             ?      133           
  Lines             ?     7883           
  Branches          ?     1941           
=========================================
  Hits              ?     6845           
  Misses            ?      640           
  Partials          ?      398
Impacted Files Coverage Δ
...c/cfnlint/rules/resources/properties/Properties.py 74.74% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8cffeb...b4d3353. Read the comment docs.

Copy link
Contributor

@cmmeyer cmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cmmeyer cmmeyer merged commit 15ae25c into aws-cloudformation:master Jul 22, 2019
@kddejong kddejong deleted the Fix/1031 branch August 3, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoValue support in NaclEntry/icmp
2 participants