Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert default values to string to check for min/max length #1063

Merged
merged 3 commits into from
Aug 1, 2019

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
Fix #1062
Description of changes:

  • Update rule E2015 to convert integers to string when testing min/max length

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #1063 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1063      +/-   ##
=========================================
+ Coverage    86.9%   86.9%   +<.01%     
=========================================
  Files         134     134              
  Lines        7935    7937       +2     
  Branches     1954    1954              
=========================================
+ Hits         6896    6898       +2     
  Misses        641     641              
  Partials      398     398
Impacted Files Coverage Δ
src/cfnlint/rules/parameters/Default.py 97.29% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5e01ae...d6986d0. Read the comment docs.

Copy link

@chuckmeyer chuckmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chuckmeyer chuckmeyer merged commit 09d7455 into aws-cloudformation:master Aug 1, 2019
@kddejong kddejong deleted the Fix/1062 branch September 2, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String misinterpreted as an int results in error on E2015
2 participants