Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max/min number types to values in spec #1116

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Sep 1, 2019

Issue #, if available:

Description of changes:

  • Add value references for new number min/max types

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

This comment has been minimized.

@chuckmeyer chuckmeyer self-requested a review September 3, 2019 14:21
Copy link

@chuckmeyer chuckmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Tested locally.

@chuckmeyer chuckmeyer merged commit de7ad54 into aws-cloudformation:master Sep 3, 2019
Comment on lines -26 to 25
{
"op": "add",
"path": "/ValueTypes/AWS::RDS::DBInstance.Iops",
"value": {
"NumberMin": 1000
}
}
Copy link
Contributor

@PatMyron PatMyron Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lost this constraint, do all these constraints need both NumberMin and NumberMax?

https://github.com/aws-cloudformation/cfn-python-lint/blob/f045b9e19ac8ceb5748b46b4606ad62ca4b80f6e/src/cfnlint/rules/resources/properties/NumberSize.py#L75

could add an arbitrarily unrealistically high NumberMax if so

@kddejong kddejong deleted the Feature/Extend1110 branch June 27, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants