Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cognito-identity keys to list of excluded resourses for Fn sub needed #1136

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Conversation

not-mike-smith
Copy link
Contributor

No Issue reported for this

Description of changes:
Add to the list of excluded resources in the SubNeeded rule (E1029) to include cognito-identity keys, and a link to their documentation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #1136 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1136   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files         135      135           
  Lines        7990     7990           
  Branches     1963     1963           
=======================================
  Hits         7013     7013           
  Misses        580      580           
  Partials      397      397
Impacted Files Coverage Δ
src/cfnlint/rules/functions/SubNeeded.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0613f70...ee2a96b. Read the comment docs.

@kddejong kddejong merged commit 812f1c1 into aws-cloudformation:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants