Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail allowed values when resource has condition #1140

Merged
merged 2 commits into from
Sep 28, 2019

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
Fix #955
Description of changes:

  • Don't fail rule W2030 when resource has a condition

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #1140 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
+ Coverage   87.77%   87.77%   +<.01%     
==========================================
  Files         135      135              
  Lines        7990     7993       +3     
  Branches     1963     1964       +1     
==========================================
+ Hits         7013     7016       +3     
  Misses        580      580              
  Partials      397      397
Impacted Files Coverage Δ
src/cfnlint/rules/parameters/AllowedValue.py 97.05% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9030950...fd02243. Read the comment docs.

@kddejong kddejong merged commit 3ebea07 into aws-cloudformation:master Sep 28, 2019
@kddejong kddejong deleted the Fix/955Again branch September 28, 2019 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

W2030 Default value required on conditionally included property
1 participant