Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't do definitionUri when using CORS #1185

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Nov 8, 2019

Issue #, if available:
Fix #1183
Description of changes:

  • Don't use DefinitionUri when using CORS in a SAM template

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #1185 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1185   +/-   ##
=======================================
  Coverage   87.78%   87.78%           
=======================================
  Files         136      136           
  Lines        8026     8026           
  Branches     1974     1974           
=======================================
  Hits         7046     7046           
+ Misses        579      578    -1     
- Partials      401      402    +1
Impacted Files Coverage Δ
src/cfnlint/transform.py 90.66% <ø> (ø) ⬆️
src/cfnlint/rules/__init__.py 88.44% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13ec30a...1a62f47. Read the comment docs.

@kddejong kddejong merged commit 67cbb58 into aws-cloudformation:master Nov 8, 2019
@kddejong kddejong deleted the Fix/1183 branch November 8, 2019 03:49
@mrpackethead
Copy link

Thanks for resolving this so quickly. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cors in serverless transform trips error
2 participants