Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle nested IF statements #1212

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
Fix #1211
Description of changes:

  • Supported nested IF statements in IF conditions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #1212 into master will increase coverage by 0.03%.
The diff coverage is 64.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
+ Coverage   87.25%   87.29%   +0.03%     
==========================================
  Files         136      136              
  Lines        8037     8043       +6     
  Branches     1974     1975       +1     
==========================================
+ Hits         7013     7021       +8     
  Misses        601      601              
+ Partials      423      421       -2
Impacted Files Coverage Δ
...c/cfnlint/rules/resources/properties/Properties.py 76.58% <64.1%> (+1.71%) ⬆️
src/cfnlint/rules/__init__.py 86.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b6848...49b2d39. Read the comment docs.

@kddejong kddejong merged commit 10da749 into aws-cloudformation:master Nov 22, 2019
@kddejong kddejong deleted the Fix/1211 branch November 22, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E3002: Property IpAddresses should be of type List for resource
1 participant