Support module paths in append_rules #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This already happens in the subsequent `extend` call.
Codecov Report
@@ Coverage Diff @@
## master #1216 +/- ##
==========================================
- Coverage 87.72% 87.71% -0.01%
==========================================
Files 136 136
Lines 8062 8069 +7
Branches 1984 1983 -1
==========================================
+ Hits 7072 7078 +6
- Misses 584 586 +2
+ Partials 406 405 -1
Continue to review full report at Codecov.
|
|
Very cool work. Should have this in shortly. |
kddejong
approved these changes
Dec 2, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #1209
This makes it so that the
append_rulesoption accepts module import paths as well as directory paths. If the value is a directory, then the existing loading operation takes place. Otherwise, the path is used as an import path, and the resulting module is scanned for rules classes in the same way as any module found by the directory scanner.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.