Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't alert on E1029 when in parameters since Sub can't be used there #1256

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
Fix #1252
Description of changes:

  • Don't alert on E1029 when looking at Parameters

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #1256 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1256      +/-   ##
==========================================
+ Coverage   87.73%   87.73%   +<.01%     
==========================================
  Files         137      137              
  Lines        8097     8099       +2     
  Branches     1989     1990       +1     
==========================================
+ Hits         7104     7106       +2     
  Misses        588      588              
  Partials      405      405
Impacted Files Coverage Δ
src/cfnlint/rules/functions/SubNeeded.py 98.48% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce9f8d...751517e. Read the comment docs.

@kddejong kddejong merged commit d1e58cb into aws-cloudformation:master Dec 16, 2019
@kddejong kddejong deleted the Fix/1252 branch December 16, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive: Sub is required if a variable is used in a string in parameter descriptions
1 participant