Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a standalone package for offline installation #1307

Merged
merged 4 commits into from
Feb 7, 2020

Conversation

jakub-bochenski
Copy link
Contributor

@jakub-bochenski jakub-bochenski commented Jan 13, 2020

Description of changes:

A convenience for offline or automated installations on Linux or macOS.
Same as the bundle for AWS CLI, which it's based on - https://github.com/aws/aws-cli/blob/1.16.314/scripts/make-bundle

It would be useful for me to have this published officially, even if only on Github (no need to host it on S3 like the AWS CLI bundle).

The goal of this script is simple:
  * Create a self contained install of the CLI that
  has requires no external resources during installation.
It does this by using all the normal python tooling
(virtualenv, pip) but provides a simple, easy to use
interface for those not familiar with the python
ecosystem.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Bocheński, Jakub and others added 3 commits January 13, 2020 14:23
@codecov

This comment has been minimized.

@kddejong kddejong self-requested a review January 19, 2020 13:14
@jakub-bochenski
Copy link
Contributor Author

Would be nice to at least get some kind of reply. Do you even consider merging this?

@kddejong
Copy link
Contributor

kddejong commented Feb 7, 2020

Sorry for the delay. Looking into this today.

So to add on to this would we also add something to pipeline to push the packages to git?

@jakub-bochenski
Copy link
Contributor Author

Thanks!

So to add on to this would we also add something to pipeline to push the packages to git?

Probably yes. Though I have no idea about the pipeline setup in this project, that's why I didn't do it.

@kddejong
Copy link
Contributor

kddejong commented Feb 7, 2020

Was able to validate this works. Double checking all the code one more time.

@kddejong kddejong merged commit 99eaa6f into aws-cloudformation:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants