Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that Rules are loaded twice when playing around a bit, the
_init__
called called twice.Found that we load the rules from disk twice, since this process loads all Python files from disk dynamically, the Rules actually get initialized twice. Waste of resources and confusion.
I removed this double loading behaviour before, but it looks like to got re-introduced in the following commit: 878f9d7
This PR "restores" this, the Rules are only loaded in in the
get_args_filenames
if the rules need to be printed.Some findings:
get_args_filenames
, that would mean that code technically something is "wrong" (like doing something else than loading the rules)... So "assumed" this changed cannot harm anything (backed by the tests BTW 😛 )initialize()
, this is a guaranteed and controlled method from the linter called when processing the rules. Might be an option to enforce using this in rules to as well...By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.