Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patched tests for EOL dates for lambda runtimes #999

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Patched tests for EOL dates for lambda runtimes #999

merged 1 commit into from
Jul 2, 2019

Conversation

chuckmeyer
Copy link

Issue #, if available:

Description of changes:
Some Lambda runtimes have moved from warning to errors for EOL. I've updated the tests to reflect this, but we may ultimately need a time sensitive way touch.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cmmeyer cmmeyer requested a review from kddejong July 2, 2019 14:00
@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #999 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
+ Coverage   86.73%   86.78%   +0.05%     
==========================================
  Files         133      133              
  Lines        7878     7878              
  Branches     1939     1939              
==========================================
+ Hits         6833     6837       +4     
- Misses        640      641       +1     
+ Partials      405      400       -5
Impacted Files Coverage Δ
src/cfnlint/__init__.py 88.61% <0%> (ø) ⬆️
...ules/resources/properties/ListDuplicatesAllowed.py 98.36% <0%> (+1.63%) ⬆️
src/cfnlint/rules/parameters/Default.py 97.22% <0%> (+2.77%) ⬆️
src/cfnlint/rules/resources/properties/ImageId.py 85.71% <0%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ae4c5...28c2ae5. Read the comment docs.

Copy link
Contributor

@kddejong kddejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should pin the dates for testing purposes.
self.collection.rules[0].current_date = datetime.datetime(2019, 6, 30) added to the setUp of the test rules so we can focus on that.

@cmmeyer cmmeyer merged commit 3189b0b into aws-cloudformation:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants