Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python S3 upload_file method #10

Closed
katiewest820 opened this issue Jan 13, 2021 · 2 comments
Closed

python S3 upload_file method #10

katiewest820 opened this issue Jan 13, 2021 · 2 comments
Assignees

Comments

@katiewest820
Copy link

Is your feature request related to a problem? Please describe.

X-Ray spans generated by S3 upload_file method requests do not have the same trace id as their parent and sibling spans and the parent_id is set to null which causes broken traces.

Describe the solution you'd like

To be able to use upload_file within our code and not have broken traces.

Describe alternatives you've considered

I had to move away from using upload_file and switch to put_object which works but if some methods are not instrumented you should call that out in the X-Ray/S3 documentation.

Additional context
Add any other context or screenshots about the feature request here.

@wangzlei
Copy link
Contributor

Hi,
Thanks for providing feedback. The is an opentelemetry python sdk issue not only happens in Lambda.
Not like put_object, boto3 S3 upload_file uses multiple threads to upload to S3 bucket, Openelemetry boto3 instrumentation cannot handle this special case and cause the span cannot find its parent span(here parent is the Lambda handler function span). Any boto3 S3 function using S3 transfer manager has the same issue, likedownload_file.
put_object can be a workaround because it is not using S3 transfer manager. I will create an issue in OpenTelemetry Python SDK to fix this bug.

@wangzlei
Copy link
Contributor

cut an issue in opentelemetry: open-telemetry/opentelemetry-python-contrib#298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants