Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add documentations to Tracing, Logging, and Metrics attributes #116

Merged
merged 7 commits into from
Jul 4, 2022

Conversation

amirkaws
Copy link
Contributor

@amirkaws amirkaws commented Mar 16, 2022

Issue #, if available:

Description of changes:

Add documentations to Tracing, Logging, and Metrics attribute classes

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added the feature New features or minor changes label Mar 16, 2022
@amirkaws amirkaws requested a review from sliedig March 16, 2022 09:19
@sliedig
Copy link
Contributor

sliedig commented Mar 25, 2022

@amirkaws can you please update the logger docs with this new functionality with examples. Thanks

@amirkaws amirkaws changed the title feat: add dependency injection support for logger feat: add documentations to Tracing, Logging, and Metrics attributes Mar 29, 2022
@amirkaws
Copy link
Contributor Author

@sliedig I used this PR for clean up and add xml documentation on top of the Tracing, Logging, and Metrics attribute classes

@sliedig sliedig merged commit 79d04c1 into develop Jul 4, 2022
@sliedig sliedig deleted the amirkaws/add-di-support-for-logging branch July 4, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants