Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): codeql static code analysis #148

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

sliedig
Copy link
Contributor

@sliedig sliedig commented Aug 4, 2022

Issue number: #125

Summary

Changes

Please provide a summary of what's being changed

Adding codeQl action to provide static code analysis (Github Advanced Security feature) for repo.

User experience

Please share what the user experience looks like before and after this change

Static code analysis will be performed per PR

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested a review from amirkaws August 4, 2022 09:51
@github-actions github-actions bot added the feature New features or minor changes label Aug 4, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@40389c4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #148   +/-   ##
==========================================
  Coverage           ?   54.95%           
==========================================
  Files              ?       37           
  Lines              ?     1685           
  Branches           ?        0           
==========================================
  Hits               ?      926           
  Misses             ?      759           
  Partials           ?        0           
Flag Coverage Δ
unittests 54.95% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sliedig sliedig added the github-actions Changes in GitHub workflows label Aug 4, 2022
Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirkaws amirkaws merged commit e81d86a into develop Aug 4, 2022
@amirkaws amirkaws deleted the sliedig-patch-codeql branch August 4, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or minor changes github-actions Changes in GitHub workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants