Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix flaky test, add relaxed json escaping #202

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Feb 8, 2023

Please provide the issue number

Issue number: #201

Summary

Currently the plus sign is escaped and transformed into "\u002B". This is not the expected behaviour because it will break bas64 encoding/decoding.

Added new test that tests a static string that contains + sign when encoded.

Changes

jsonOptions.Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping;

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested a review from amirkaws February 8, 2023 18:47
@github-actions github-actions bot added the bug Unexpected, reproducible and unintended software behaviour label Feb 8, 2023
@hjgraca hjgraca mentioned this pull request Feb 8, 2023
7 tasks
Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sliedig sliedig merged commit dbd4bf3 into aws-powertools:develop Feb 14, 2023
@sliedig sliedig added the pending-release Fix or implementation already in dev waiting to be released label Feb 14, 2023
@hjgraca hjgraca linked an issue Feb 17, 2023 that may be closed by this pull request
@hjgraca hjgraca deleted the fix-test-json-escaping branch April 12, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected, reproducible and unintended software behaviour pending-release Fix or implementation already in dev waiting to be released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Flaky test due to json escaping when plus sign present
3 participants