-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ASP.NET Core WebAPI example(s) #287
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #287 +/- ##
===========================================
+ Coverage 69.09% 69.11% +0.01%
===========================================
Files 79 79
Lines 3433 3448 +15
===========================================
+ Hits 2372 2383 +11
- Misses 1061 1065 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
HI @amirkaws I did address your comment:) please check the PR. |
Hi @swimming-potato, thank you a lot for that. I think we are still missing copyright comments, we should add Amazon copyright comment on top of each .cs file. The other thing I believe we should add is a solution file in the example root folder to include both projects juts to be consistent with the. other examples. here is an example for logging https://github.com/aws-powertools/powertools-lambda-dotnet/blob/develop/examples/Logging/PowertoolsLoggingExample.sln |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the solution to PowertoolsServerlessApiExample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Small solution name change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for a great work @swimming-potato ! |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #220
Summary
Changes
Introduce an example for ASP.Net WebAPI deployed on AWS Lambda.
User experience
This is a change in documentation. A section
ServerlessAPi
has been added to the examples. The section demonstrates to AWS Lambda Powertools users: how to leverage logging, metrics and tracing provided by AWS Lambda Powertools in the WebAPI hosted by Kestrel. It contains the code and README.md file to walkthrough the changes.Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
No **RFC issue number**:Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.