Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Warn users when adding multiple values to dimension before flushing #3350

Closed
1 of 2 tasks
allenheltondev opened this issue Nov 23, 2024 · 3 comments · Fixed by #3352
Closed
1 of 2 tasks
Assignees
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility metrics This item relates to the Metrics Utility

Comments

@allenheltondev
Copy link

Use case

In reference to this post, when a user adds multiple values to a single dimension before flushing metrics, only the last value set on the dimension wins.

Solution/User Experience

It would be nice if the metrics object would do a console.warn when multiple distinct values are used on a single dimension before flushing. Current behavior uses the last value added to the dimension.

Alternative solutions

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@allenheltondev allenheltondev added feature-request This item refers to a feature request for an existing or new utility triage This item has not been triaged by a maintainer, please wait labels Nov 23, 2024
Copy link

boring-cyborg bot commented Nov 23, 2024

Thanks for opening your first issue here! We'll come back to you as soon as we can.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

@dreamorosi dreamorosi moved this from Triage to Backlog in Powertools for AWS Lambda (TypeScript) Nov 24, 2024
@dreamorosi dreamorosi moved this from Backlog to Working on it in Powertools for AWS Lambda (TypeScript) Nov 24, 2024
@dreamorosi dreamorosi added metrics This item relates to the Metrics Utility confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Nov 24, 2024
@dreamorosi dreamorosi self-assigned this Nov 24, 2024
@dreamorosi
Copy link
Contributor

Hi @allenheltondev, nice to see you here!

I agree with the discussion you and @leandrodamascena had in the linked thread, we should emit a warning when this happens.

I have opened a PR to introduce the change, once merge it'll be included in the next release.

Copy link
Contributor

This is now released under v2.12.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility metrics This item relates to the Metrics Utility
Projects
Status: Coming soon
Development

Successfully merging a pull request may close this issue.

2 participants