Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: feature parity with Python Powertools logger #482

Closed
7 of 8 tasks
saragerion opened this issue Jan 18, 2022 · 2 comments · Fixed by #1004
Closed
7 of 8 tasks

Feature request: feature parity with Python Powertools logger #482

saragerion opened this issue Jan 18, 2022 · 2 comments · Fixed by #1004
Assignees
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation feature-request This item refers to a feature request for an existing or new utility logger This item relates to the Logger Utility

Comments

@saragerion
Copy link
Contributor

saragerion commented Jan 18, 2022

Description of the feature request

As addressed in this comment, we should revisit the current features of the Logger to make sure there is feature parity.

Some of the mentioned items are not listed as they are captured by another ticket.

Problem statement

The Logger utility has a number of functionalities shipped in 2021 that are currently not in TS.

Summary of the feature

For each functionality above:

  • Evaluate if the feature should be ported (does it make sense for the TS ecosystem?) or can't be ported because of language's different behaviour

If it can and should be ported:

  • Business logic
  • Unit tests
  • E2E tests
  • Examples
  • JsDocs (when applicable)
  • Documentation

For this reason it's recommended that whoever picks this issue should create one separated PR for each checklist item.

Code examples

N/A

Benefits for you and the wider AWS community

Feature parity with the Python Powertool.

Describe alternatives you've considered

N/A

Additional context

N/A

Related issues, RFCs

N/A

@saragerion saragerion added documentation Improvements or additions to documentation enhancement triage This item has not been triaged by a maintainer, please wait labels Jan 18, 2022
@saragerion saragerion added this to the production-ready-release milestone Jan 18, 2022
@saragerion saragerion self-assigned this Jan 20, 2022
@saragerion saragerion removed the triage This item has not been triaged by a maintainer, please wait label Jan 20, 2022
@saragerion saragerion added the logger This item relates to the Logger Utility label Jan 25, 2022
@dreamorosi dreamorosi changed the title Logger: feature parity with Python powertool Feature (logger): feature parity with Python Powertools May 12, 2022
@saragerion saragerion linked a pull request Jun 23, 2022 that will close this issue
13 tasks
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@saragerion
Copy link
Contributor Author

Note: the location logic will be discussed further and captured in another PR, as agreed with @flochaz and @dreamorosi

@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility labels Nov 14, 2022
@dreamorosi dreamorosi changed the title Feature (logger): feature parity with Python Powertools Feature request: feature parity with Python Powertools Nov 14, 2022
@dreamorosi dreamorosi changed the title Feature request: feature parity with Python Powertools Feature request: feature parity with Python Powertools logger Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation feature-request This item refers to a feature request for an existing or new utility logger This item relates to the Logger Utility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants