Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configuration option to control the type of colcon-bundle installation (from pip or source) #36

Open
AAlon opened this issue Jun 18, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@AAlon
Copy link
Contributor

AAlon commented Jun 18, 2019

We're currently installing colcon bundle from source due to an issue with the version that exists in pip.

Once colcon bundle is released to pip (along with the following commit: colcon/colcon-bundle@d5ea60e) we should remove the installation from source.

Related to PR #35

@AAlon AAlon added the enhancement New feature or request label Jun 18, 2019
@AAlon
Copy link
Contributor Author

AAlon commented Jun 18, 2019

After discussing with @raghaprasad, we agreed the path forward should be to support an additional build job which would use colcon-bundle from source. So rather than removing the installation from source, we should guard it inside an if condition and provide that flag via .travis.yml.
Changing the title accordingly.

@AAlon AAlon changed the title Use pip installation of colcon bundle Add a configuration option to control the type of colcon-bundle installation (from pip or source) Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant